Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase JAXB extension test coverage #3902

Merged
merged 2 commits into from Jul 6, 2022

Conversation

jamesnetherton
Copy link
Contributor

Note: impsort-maven-plugin upgraded as the older version does not seem to deal with jaxb.index properly.

@aldettinger
Copy link
Contributor

There are usages of java.lang.reflect.Method in camel JaxbDataFormat.java, JaxbHelper.java and FallBackConverterType.java.

Shouldn't we have a kind of reflection config or doc accordingly ?

@jamesnetherton
Copy link
Contributor Author

Shouldn't we have a kind of reflection config or doc accordingly ?

Possibly not in this case because the reflective class config is being handled by quarkus-jaxb. Although, I am missing a test to verify this so I'll add one to make sure.

@aldettinger
Copy link
Contributor

Okay great and it makes sense now that quarkus-jaxb would bring some reflective config too 👍

@jamesnetherton
Copy link
Contributor Author

Latest commit adds a new test marshalWithObjectFactory and includes some docs about ObjectFactory and reflection.

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, well done @jamesnetherton 👏

@jamesnetherton jamesnetherton merged commit 420f0fd into apache:main Jul 6, 2022
@jamesnetherton jamesnetherton deleted the jaxb-tests branch July 6, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants