Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
oscerd
approved these changes
Nov 11, 2019
ppalaga
reviewed
Nov 11, 2019
...ons/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSupport.java
Outdated
Show resolved
Hide resolved
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastTypeConverter.java
Outdated
Show resolved
Hide resolved
|
The default type registry does it's own class-path scanning and does not offer an hook for quarkus idiomatic injection of a custom type converter loaders, this PR aims to leverage Quarkus facilities to discover resource files at build time and add an option to inject custom type converter using a build item. |
ppalaga
approved these changes
Nov 11, 2019
|
ok to test |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389