Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to the Jackson ObjectMapper usage section #3952

Merged
merged 1 commit into from Aug 3, 2022

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Aug 2, 2022

Relates to #3937
Would you mind to review @jamesnetherton?

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing to fix for the Quarkus Jackson ObjectMapper case. Otherwise LGTM.


public class Routes extends RouteBuilder {
public void configure() {
ObjectMapper mapper = new ObjectMapper();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake here. You don't actually need to instantiate ObjectMapper in this scenario because JacksonDataFormat will resolve the Quarkus one from the Camel registry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@ppalaga ppalaga merged commit f4fcdc7 into apache:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants