Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial JMS support #430

Merged
merged 1 commit into from Nov 18, 2019
Merged

Initial JMS support #430

merged 1 commit into from Nov 18, 2019

Conversation

lburgazzoli
Copy link
Contributor

See #424

@lburgazzoli
Copy link
Contributor Author

ok to test

@asf-ci
Copy link

asf-ci commented Nov 15, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/407/

@oscerd oscerd merged commit 9a18c74 into apache:master Nov 18, 2019
@lburgazzoli lburgazzoli deleted the sjms branch November 18, 2019 08:11
ppalaga
ppalaga reviewed Nov 18, 2019
View reviewed changes
extensions/sjms/runtime/pom.xml
<name>Camel Quarkus :: SJMS :: Runtime</name>

<properties>
<firstVersion>0.4.1</firstVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding extensions in a micro release sounds wrong. Should be either 0.5.0 (or maybe 1.0.0.RC1?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has already been fixed

@lburgazzoli
Copy link
Contributor Author

@ppalaga, it has been fixed already

ppalaga
ppalaga reviewed Nov 18, 2019
View reviewed changes
extensions/sjms/runtime/src/main/resources/META-INF/quarkus-extension.yaml

---
name: "Camel Quarkus SJMS"
description: "Camel Quqrkus JMS support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quqrkus :-D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has already been merged, you are very welcome to fix findings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppalaga ppalaga ppalaga left review comments

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lburgazzoli @asf-ci @ppalaga @oscerd