Add FTP extension #464
Add FTP extension #464
Conversation
|
ok to test |
|
Just realised I need to fix up the |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-ftp: 1 |
|
Can anyone else replicate this test failure in native mode? It's working fine for me. |
|
I think you may need to declare that you need ssl, like https://github.com/apache/camel-quarkus/blob/master/extensions/aws-s3/deployment/src/main/java/org/apache/camel/quarkus/component/aws/s3/deployment/AwsS3Processor.java#L59 |
|
ok to test |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-ftp: 1 |
|
mmh, does not fails for me neither but still failing on jenkins... maybe something caused by the oracle jdk vs openjdk ? |
|
Yes, it's weird. I tested with the same JDK version Jenkins uses and it still passes. |
|
There’s an open issue here: quarkusio/quarkus#2125 |
|
Wondering if the Jenkins build environment is configured correctly? If I unset Maybe the other extensions that require native SSL support don't trigger the relevant code paths in their integration tests (AWS, Twitter & Salesforce tests don't run at all). Hence why we perhaps haven't hit this before. |
|
I think the main problem is that the code is built with docker but executed outside it, do you mind adding some notes to the linked issue or starting a conversation on zulip ? |
|
ok to test |
|
Refer to this link for build results (access rights to CI server needed): |
|
All is green, lets merge ? We can maybe mark this extension as preview |
|
Lets merge as-is. IMO it works fine in native mode when the environment is configured correctly. I raised #468 as a follow up issue. |
fixes #463