Add MongoDB extension #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Nov 27, 2019
ppalaga
reviewed
Nov 27, 2019
| @Produces | ||
| @Singleton | ||
| @Named("camelMongoClient") | ||
| public com.mongodb.MongoClient camelMongoClient(MongoClient delegate) { |
There was a problem hiding this comment.
Can't we install the com.mongodb.MongoClient into the Camel registry using MongoClientBuildItem ? Avoiding CDI could bring some performance benefits.
There was a problem hiding this comment.
I'll see if it's possible.
There was a problem hiding this comment.
Latest changes remove the CDI bits in favour of MongoClientBuildItem.
jamesnetherton
force-pushed
the
camel-mongodb-extension
branch
from
095e359
to
873684a
Compare
ppalaga
approved these changes
Nov 27, 2019
|
ok to test |
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #302