Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Camel K Runtime fixups #5219

Merged
merged 1 commit into from Aug 30, 2023
Merged

Onboard Camel K Runtime fixups #5219

merged 1 commit into from Aug 30, 2023

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Aug 23, 2023

Some enhancements on top of #5117

@ppalaga ppalaga mentioned this pull request Aug 23, 2023
@jamesnetherton
Copy link
Contributor

Are we proposing to merge this for 3.2.0?

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 23, 2023

Are we proposing to merge this for 3.2.0?

That's a good question. I think it would be very practical to have this in the LTS. Any opinion, @claudio4j?

@jamesnetherton
Copy link
Contributor

I think it would be very practical to have this in the LTS

I was thinking the reverse 🙂. We are effectively done with 3.2.0, not sure I like introducing a change like this at this stage. Safer to defer for 3.3.0 IMO.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 23, 2023

I was thinking the reverse 🙂. We are effectively done with 3.2.0, not sure I like introducing a change like this at this stage. Safer to defer for 3.3.0 IMO.

I won't stand in a way then.

@claudio4j
Copy link
Contributor

Thanks Peter.
@jamesnetherton This onboard to a camel-quarkus release will give us a important opportunity to decrease dependency of camel-k-runtime. Also, given that camel-k-runtime extension should not be visible or usable for regular camel-quarkus, I would say this onboard has very minimal risk to disrupt anything in camel-quarkus applications.

@zhfeng
Copy link
Contributor

zhfeng commented Aug 24, 2023

I'm also not confident to introduce such a big change in last minute before releasing 3.2.0. I think @zbendhiba is preparing for the new release this week. WDYT?

@zbendhiba
Copy link
Contributor

I was thinking of releasing 3.3.0 very soon after 3.2.0, so that we go back to the release cadence we used to have before. The 2 versions will be based on Camel 4, but 3.2.0 is an LTS.
I also think it makes sense to have the experimental stuff for 3.3.0 and Camel k team will have quickly 3.3.0 to start experimenting stuff. is that makes sense for you @claudio4j ?

@zhfeng
Copy link
Contributor

zhfeng commented Aug 24, 2023

It looks like camel-k-runtime tests are failing on windows build due to lack of Docker environment.

@zhfeng
Copy link
Contributor

zhfeng commented Aug 24, 2023

@zbendhiba For releasing 3.3.0, please make sure we have all changes in

@aldettinger
Copy link
Contributor

With Camel-K 2.0, we should already have less coupling between Camel Quarkus and Camel-K ? So that should be ok to merge this pr in next 3.3.0 release ?

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 24, 2023

It looks like camel-k-runtime tests are failing on windows build due to lack of Docker environment.

Thanks for having a look @zhfeng! I am away for a RH event today and I'll be able to address this only tomorrow.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 25, 2023

866fe21:

  • Rebased
  • Squashed all commits
  • Added skip-testcontainers-tests profile to the new Camel K test module
        <profile>
            <id>skip-testcontainers-tests</id>
            <activation>
                <property>
                    <name>skip-testcontainers-tests</name>
                </property>
            </activation>
            <properties>
                <skipTests>true</skipTests>
            </properties>
        </profile>

@claudio4j
Copy link
Contributor

I was thinking of releasing 3.3.0 very soon after 3.2.0, so that we go back to the release cadence we used to have before. The 2 versions will be based on Camel 4, but 3.2.0 is an LTS. I also think it makes sense to have the experimental stuff for 3.3.0 and Camel k team will have quickly 3.3.0 to start experimenting stuff. is that makes sense for you @claudio4j ?

Sounds good to me, thanks for the feedback everyone.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 28, 2023

So there seems to exist an agreement that this PR should aim 3.3.0.
Hence I am going to rebase this after we release 3.2.0.

@ppalaga ppalaga marked this pull request as draft August 28, 2023 09:05
@ppalaga ppalaga marked this pull request as ready for review August 30, 2023 09:25
@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 30, 2023

5c4c745:

@ppalaga ppalaga merged commit 93d6053 into apache:main Aug 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants