Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commons-logging setup #545

Merged
merged 2 commits into from Dec 13, 2019
Merged

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the cleanup.

So the rule you are hereby coining is that we should exclude in the BOM rather than in the runtime modules, right?

We could actually ban commons-logging via an enforcer rule, WDYT?

@lburgazzoli
Copy link
Contributor Author

+1 for the cleanup.

So the rule you are hereby coining is that we should exclude in the BOM rather than in the runtime modules, right?

I would say yes but no strong opinion on it, what's your ?

We could actually ban commons-logging via an enforcer rule, WDYT?

Yes we should

@lburgazzoli
Copy link
Contributor Author

ok to test

@ppalaga
Copy link
Contributor

ppalaga commented Dec 13, 2019

So the rule you are hereby coining is that we should exclude in the BOM rather than in the runtime modules, right?

I would say yes but no strong opinion on it, what's your ?

I do not mind such a rule, neither I have a strong opinion about where it should be done.

@lburgazzoli
Copy link
Contributor Author

I do not mind such a rule, neither I have a strong opinion about where it should be done.

So let's see how it goes

@asf-ci
Copy link

asf-ci commented Dec 13, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/483/

@lburgazzoli lburgazzoli merged commit cac308c into apache:master Dec 13, 2019
@lburgazzoli lburgazzoli deleted the commons-logging branch December 13, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants