Unshade Google and Micrometer related packages from kudu-client #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we perhaps unshade also com.sangupta:murmur? |
…o Protobuf UnsafeUtil sun.misc.Unsafe access
jamesnetherton
force-pushed
the
kudu-client-unshade
branch
from
5a00e99
to
633d642
Compare
Latest commit unshades murmur. |
ppalaga
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ppalaga WDYT about this? Do you think it's safe to unshade more libraries from the Kudu client?
The only thing left shaded with this change is
com.sangupta:murmur. Which I did not bother to unshade given it's quite old, only had one previous release, has no third party dependencies and only contains 4 classes.