New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for #543 #581
Add tests for #543 #581
Conversation
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test per se looks good, but I do not understand how is this supposed to work on the Quarkus Platform? I see you disabled the new test on the platform, but I suspect the test container won't even start due to the missing my-routes.xml
file? Can't we make the my-routes.xml
a classpath resource and keep the new test enabled on the platform?
We can but then we need to include the routes in the native image which is not yet done automatically, in general we should not assume that all the test have to run on the quarkus-platform |
I'd vote for including the XML file in the native image via application.properties' for now:
Not sure this will work OOTB on the platform, but it is a bit more flexible than
I think we should assume that all our tests should run there unless we define a clear filtering strategy. |
Peter, we already agreed that we need to create some consolidated test for the quarkus platform. |
54acc8a
to
9396669
Compare
9396669
to
c317614
Compare
xml is now included in the native image |
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
No description provided.