Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enforce profile that disables dependency checks #679

Merged
merged 1 commit into from Feb 4, 2020
Merged

Create enforce profile that disables dependency checks #679

merged 1 commit into from Feb 4, 2020

Conversation

johnpoth
Copy link
Member

@johnpoth johnpoth commented Feb 4, 2020

Hello,

Often when developing I find myself commenting out these checks so I moved them into a profile? To disable checking one can set the dev property e.g maven clean install -Ddev. Thanks !

ppalaga
ppalaga reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, with the idea, but could you plz propose some other property name? dev (mode) already has a meaning in the Quarkus world. Could you please pick something deps/enforcement related?

oscerd
oscerd approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for me, but please change the profile name. Naming is hard.

@johnpoth
Copy link
Member Author

johnpoth commented Feb 4, 2020

@ppalaga @oscerd naming is hard ! How about rules, check,enforce, constraints ? We would disable it by setting -Dcheck=false or -Denforce=false etc...

@oscerd
Copy link
Contributor

oscerd commented Feb 4, 2020

Sounds good for me.

@ppalaga
Copy link
Contributor

ppalaga commented Feb 4, 2020

-Denforce=false or also -DnoEnforce sound acceptable

@johnpoth johnpoth changed the title Create dev profile that disables dependency checks Create enforce profile that disables dependency checks Feb 4, 2020
@johnpoth
Copy link
Member Author

johnpoth commented Feb 4, 2020

@ppalaga @oscerd I've renamed the profile name to 'enforce'. I think it is clearer when names don't have negations in them (so here I've preferred 'enforce' as opposed to 'no-enforce'). Also the profile does enforce sanity checks so it makes sense IMO. Hope it's okay, thanks !

@oscerd oscerd merged commit ea2b52c into apache:master Feb 4, 2020
@johnpoth johnpoth deleted the dev-profile branch February 4, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppalaga ppalaga ppalaga approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnpoth @oscerd @ppalaga