New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test packages to org.apache.camel #77
Conversation
5ef9d37
to
34b7b52
Compare
Refer to this link for build results (access rights to CI server needed): Build result: ABORTED[...truncated 193.90 KB...][INFO] [INFO] --- maven-surefire-plugin:2.22.0:test (default-test) @ camel-quarkus-integration-test-aws-s3 ---[INFO] Tests are skipped.[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 44 iota=62[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: Invalid object ID 44 iota=62[INFO] [INFO] --- maven-jar-plugin:3.1.0:jar (default-jar) @ camel-quarkus-integration-test-aws-s3 ---[INFO] Building jar: /home/jenkins/jenkins-slave/workspace/camel-quarkus-pr/integration-tests/aws-s3/target/camel-quarkus-integration-test-aws-s3-0.0.1-SNAPSHOT.jar[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: java.util.concurrent.ExecutionException: Invalid object ID 44 iota=62[INFO] [INFO] --- quarkus-maven-plugin:999-SNAPSHOT:build (default) @ camel-quarkus-integration-test-aws-s3 ---[INFO] [io.quarkus.deployment.QuarkusAugmentor] Beginning quarkus augmentationBuild was abortedAborted by acosentino[INFO] [io.quarkus.deployment.QuarkusAugmentor] Quarkus augmentation completed in 1510ms[INFO] [io.quarkus.creator.phase.runnerjar.RunnerJarPhase] Building jar: /home/jenkins/jenkins-slave/workspace/camel-quarkus-pr/integration-tests/aws-s3/target/camel-quarkus-integration-test-aws-s3-0.0.1-SNAPSHOT-runner.jarchannel stopped[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: hudson.remoting.Channel$OrderlyShutdown: Command Close created at[INFO] [INFO] --- maven-site-plugin:3.7.1:attach-descriptor (attach-descriptor) @ camel-quarkus-integration-test-aws-s3 ---Adding one-line test results to commit status...Setting status of 34b7b52 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/21/ and message: 'FAILURE 3 tests run, 0 skipped, 0 failed.'Using context: default |
34b7b52
to
3a6cc1b
Compare
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 375.11 KB...] at java.lang.reflect.Method.invoke (Method.java:498) at hudson.maven.Maven3Builder.call (Maven3Builder.java:139) at hudson.maven.Maven3Builder.call (Maven3Builder.java:70) at hudson.remoting.UserRequest.perform (UserRequest.java:212) at hudson.remoting.UserRequest.perform (UserRequest.java:54) at hudson.remoting.Request$2.run (Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run (FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624) at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of 3a6cc1b to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/25/ and message: 'FAILURE 12 tests run, 0 skipped, 4 failed.'Using context: default |
Refer to this link for build results (access rights to CI server needed): Failed Tests: 4camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-core: 2
camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-jdbc: 2 |
434441b
to
4858dde
Compare
Refer to this link for build results (access rights to CI server needed): Failed Tests: 4camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-core: 2
camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-jdbc: 2 |
4858dde
to
cedc192
Compare
Refer to this link for build results (access rights to CI server needed): Failed Tests: 3camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-infinispan: 1camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-netty4-http: 2 |
35863a6
to
e2a03c7
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
@ppalaga added snapshot profile active by default for the moment as there were some changes in quarkus like moving to GraalVM 19.1.1 that have introduced some regressions, will disable this profile after quarkus 0.20.0 |
@@ -14,7 +14,7 @@ | |||
* See the License for the specific language governing permissions and | |||
* limitations under the License. | |||
*/ | |||
package io.quarkus.it.camel.aws; | |||
package org.apache.camel.quarkus.component.aws; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for keeping it
somewhere in the integration test package names. org.apache.camel.quarkus.component.aws.it
or org.apache.camel.quarkus.it.component.aws
or some other variant. This is to avoid any potential naming clashes with the the platform code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I do usually keep the same name is to be able to access package private methods/classes for testing purpose, I can change it but I propose to do it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be able to access package private methods/classes for testing purpose
Yes, that's normal and OK for unit tests. OTOH integration tests should simulate how our end users use camel quarkus. We should not assume that they access non-public APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's partially true as we do not have any unit test for the native image side of things
e2a03c7
to
8c9854d
Compare
If there is any chance to re-think this proposal for the sake of build reproducibility and portability please consider using srcdeps instead of Maven SNAPSHOTs. I have sent a PR against your branch: lburgazzoli#1 |
@ppalaga 0.20.0 is expected to be released in 5 days (week-end included) and after that release the snapshot profile won't be active by default as already stated above. We need to be sure the code compile against the latest quarkus bits to avoid last minute bugs that would delay a first official release even further. Unfortunately srcdeps stick with a specific commit and won't give us an option to spot such problems. |
Refer to this link for build results (access rights to CI server needed): |
No description provided.