Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single integration test module for the AWS extensions #85

Merged
merged 1 commit into from Jul 24, 2019

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Jul 24, 2019

No description provided.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in the chat, a README documenting the required env vars would be nice to have.

@@ -27,15 +27,28 @@
</parent>
<modelVersion>4.0.0</modelVersion>

<artifactId>camel-quarkus-integration-test-aws-sns</artifactId>
<name>Camel Quarkus :: Integration Tests :: AWS SNS</name>
<artifactId>camel-quarkus-integration-test-aws-itests</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the name of the directory aws-itests and the name of the artifactId camel-quarkus-integration-test-aws-itests does not match the naming convention used in all other itests. Would you mind changing the dir to aws and artifactId to camel-quarkus-integration-test-aws?

@asf-ci
Copy link

asf-ci commented Jul 24, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/30/

@oscerd oscerd merged commit e53ab42 into master Jul 24, 2019
@oscerd
Copy link
Contributor Author

oscerd commented Jul 24, 2019

I'll change this now

@oscerd oscerd deleted the aws-single-itest branch July 24, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants