Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveMQ extension #860

Merged
merged 1 commit into from Mar 9, 2020
Merged

Conversation

jamesnetherton
Copy link
Contributor

Fixes #424

@lburgazzoli
Copy link
Contributor

Wonder if it could make sense to put this among the messaging it

@jamesnetherton
Copy link
Contributor Author

Messaging has JMS 2 on the classpath so it potentially leads to false positives when testing. Hence I chose to separate into its own itest module.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a tiny nitpick inline

metadata:
keywords:
- "camel"
- "ActiveMQ"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think used lower case quite consequently so far.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it in a follow up commit. AFAIK, the keyword search on code.quarkus.io is case insensitive, so it'll still work fine with a mixture of upper & lower case.

@jamesnetherton jamesnetherton merged commit 17eb6d1 into apache:master Mar 9, 2020
@jamesnetherton jamesnetherton deleted the activemq branch March 9, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for camel-activemq
4 participants