Add GraphQL extension #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 10, 2020
ppalaga
reviewed
Mar 10, 2020
|
|
||
| @BuildStep | ||
| ExtensionSslNativeSupportBuildItem activateSslNativeSupport() { | ||
| return new ExtensionSslNativeSupportBuildItem(FEATURE); |
There was a problem hiding this comment.
Is SSL really required for everybody? I think we agreed with @lburgazzoli that we should mention this in the extension doc page and let the users decide whether they need it or not. It is similar with encodings and time zones.
There was a problem hiding this comment.
I mean users should enable those things via their application.properties
There was a problem hiding this comment.
In this case, there's stuff in HttpClientBuilder that wants to configure an SSLContext by default. Not sure if I should be looking to suppress that stuff (probably not).
| * Query files that only need to be accessible from the classpath should be specified on this property. | ||
| * | ||
| * Paths can either be schemeless (E.g graphql/my-query.graphql) or be prefixed with the classpath: URI scheme (E.g | ||
| * classpath:graphql/my-query.graphql). Other URI schemes are not supported. |
There was a problem hiding this comment.
I appreciate the well written the doc text!
ppalaga
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #801