Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The first JVM-only extension #895

Merged
merged 3 commits into from Mar 17, 2020
Merged

The first JVM-only extension #895

merged 3 commits into from Mar 17, 2020

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Mar 16, 2020 •
edited

Fix #894

@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 16, 2020

Any feedback is appreciated.

jamesnetherton
jamesnetherton reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just a minor comment about firstVersion

tooling/create-extension-templates/runtime-pom.xml Outdated Show resolved Hide resolved
tooling/create-extension-templates/quarkus-extension.yaml Show resolved Hide resolved
@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 16, 2020

There are two things missing:

  • Running the JVM-only tests by the CI
  • Listing the JVM-only extensions in the docs

@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 16, 2020

There are two things missing:

  • Running the JVM-only tests by the CI

It should already be covered by the build jobs's mvn clean install.

  • Listing the JVM-only extensions in the docs

Can be done as a followup.

@ppalaga ppalaga marked this pull request as ready for review March 16, 2020 21:50
@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 16, 2020 •
edited

ec0ec5f:

  • Fixed the M5/6 issue found by @jamesnetherton
  • Replaced the plugin refs in the docs
  • Used the proper release of the plugin to generate the extension

@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 16, 2020

Another followup: some source checks may need a reconfig

This was referenced Mar 17, 2020
Closed
Closed
@ppalaga
Copy link
Contributor Author

ppalaga commented Mar 17, 2020

@jamesnetherton reviewed and agreed to merge

@ppalaga ppalaga merged commit 33603d2 into apache:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnetherton jamesnetherton jamesnetherton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elastichsearch Rest support
2 participants
@ppalaga @jamesnetherton