New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #897 List the JVM-only extensions in the docs #898
Conversation
d51d679 fixed the failing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License checks are failing but otherwise looks good to me.
e4543eb fixed the license header issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not move the functionalities of the package-maven-plugin outside of the camel-quarkus repository as it will introduces yet another external dependency not under direct control of Apache Camel commiters.
In addition it creates a dependency issue as to update to a new version of Apache Camel would require to update the plugin first.
It is true that not every Apache Camel committer has access, but OTOH, there are more than one Apache Camel committer that do have write access there. The motivation was threefold:
Moving the mojos to a separate repo under the ASF umbrella would mean loosing the flexibility of releasing on demand. My understanding is that the voting process cannot be relaxed even for tools like these, right? So if you insist on your veto, I am going to move the changes back to camel-quarkus.
This is not an issue, as long as camel-catalog stays backwards compatible, because it is managed on the Camel Quarkus side https://github.com/apache/camel-quarkus/pull/898/files#diff-600376dffeb79835ede4a0b285078036R239-R243 |
I think it is fine to have the extension generator outside the camel-quarkus repo as it is an optional thing but for the catalog generator and other functionalities provided by the package maven plugin it would be a bad move so IMHO we should be keep it as part of the camel-quarkus repo. @davsclaus @gnodet @oscerd what don you think ? |
Yes the quarkus camel catalog should be here, this is what we do in other projects too. |
00e3c63 brings the mojos back to the Camel Quarkus source tree |
d93f2be should fix the test failure. |
0f9eef7 fixed the create mojo config |
Fix #897