POM enhancements #903
Merged
POM enhancements #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pom.xml
Outdated
| @@ -84,8 +84,7 @@ | |||
| <maven-source-plugin.version>3.1.0</maven-source-plugin.version> | |||
| <maven-assembly-plugin.version>3.1.1</maven-assembly-plugin.version> | |||
| <maven-dependency-plugin.version>3.1.1</maven-dependency-plugin.version> | |||
| <!-- NOTE: We pin to this version due to https://github.com/apache/camel-quarkus/issues/723 --> | |||
| <maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version> | |||
| <maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version> | |||
There was a problem hiding this comment.
I'm not convinced all of the issues are fixed.
Run NoDefaultServletTest (You'll need to remove @Disabled) and the test passes with 3.x. Run it with 2.x and it'll fail.
There was a problem hiding this comment.
That would mean that quarkusio/quarkus#7203 is not fully fixed? Let me remove the commit then.
ppalaga
force-pushed
the
200318-enforcer
branch
from
fd64093
to
2e07491
Compare
ppalaga
force-pushed
the
200318-enforcer
branch
from
2e07491
to
149d0da
Compare
|
149d0da removed the revert to maven-surefire-plugin.version 3.0.0-M4 Do we want to wait for the CI? |
Actually, we should, because I also rebased. |
|
Approved by @jamesnetherton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.