Add AMQP extension #968
Merged
Add AMQP extension #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Mar 24, 2020
ppalaga
reviewed
Mar 24, 2020
Comment on lines
+39
to
+62
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-bom-deployment</artifactId> | ||
| <version>${quarkus.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.amqphub.quarkus</groupId> | ||
| <artifactId>quarkus-qpid-jms-deployment</artifactId> | ||
| <version>${quarkus.qpid.jms.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| <!-- quarkus-qpid-jms-deployment is currently not part quarkus-qpid-jms-deployment--> | ||
| <dependency> | ||
| <groupId>org.amqphub.quarkus</groupId> | ||
| <artifactId>quarkus-qpid-jms-deployment</artifactId> | ||
| <version>${quarkus.qpid.jms.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> |
There was a problem hiding this comment.
I'd expect these to be in the deployment module. Is there any reason for them to be here in the parent?
There was a problem hiding this comment.
By importing the deployment BOMs here in the parent, we awake an impression that it is legal to use the deployment artifacts in all descendants, incl. the runtime module, which I think really should not happen.
There was a problem hiding this comment.
I'll fix this (for amqp).
I also noticed some other extensions where this happens. I'll follow up with another PR to fix tomorrow.
There was a problem hiding this comment.
I have some dep. management cleanup in progress. I'd fix all these things there, if you do not mind.
ppalaga
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143