✨ CAMEL-18449 platform-http servlet implementation #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can have dependency on camel-servlet that is okay, then you do not need to use reflection |
|
Thank you @davsclaus, I've updated it and created the following example apache/camel-spring-boot-examples#83 |
davsclaus
approved these changes
Sep 5, 2022
bsmolicek
pushed a commit
to jboss-fuse/camel-spring-boot
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to use camel-platform-http-starter and camel-servlet-starter without any additional configuration.
If camel-servlet is configured in the context (camel-servlet-starter is declared as a dependency), then a PlatformHttpEngine implementation is created using the servlet, I'm not 100% sure about the reflection, if you think it can be done in some other way please let me know.