Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed blog page categories issue #222

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fixed blog page categories issue #222

merged 1 commit into from
Mar 26, 2020

Conversation

jyotiattri
Copy link
Contributor

Implemented the requested changes from #213

oscerd
oscerd requested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doing this PR if #213 hasn't been merged yet?

@jyotiattri
Copy link
Contributor Author

Is there any problem with code @zregvart. Please let me know.

@oscerd
Copy link
Contributor

oscerd commented Mar 16, 2020

I restarted the build.

@jyotiattri
Copy link
Contributor Author

"Can you also squash commits into a single one?" @zregvart send this comment in #213 that why I squash commit in single PR. Is there anything I have done wrong.

@oscerd
Copy link
Contributor

oscerd commented Mar 16, 2020

I don't think so, but if this is the squashed one, please close the other PR. Otherwise there is confusion.

@jyotiattri jyotiattri mentioned this pull request Mar 16, 2020
Closed
@jyotiattri
Copy link
Contributor Author

Closed the PR #213

@jyotiattri
Copy link
Contributor Author

Hi, @zregvart
Please let me know is there something to do in this PR.

@zregvart
Copy link
Member

The preview is here.

zregvart
zregvart approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the left hand side categories that would be put at the bottom of the screen on < 1024 width screens.

LGTM.

@zregvart zregvart merged commit a9594dc into apache:master Mar 26, 2020
@zregvart
Copy link
Member

Thanks!

@AemieJ AemieJ mentioned this pull request Mar 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd requested changes

@zregvart zregvart zregvart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jyotiattri @oscerd @zregvart