Fixed issue for text too small for pages #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @zregvart |
zregvart
requested changes
Mar 24, 2020
There was a problem hiding this comment.
I don't think this is a good approach, it is very complex way of deriving a font size and it introduces additional media breakpoints that will make it difficult for us to maintain the CSS in the future.
All the font sizes are calculated from --rem-base and root --doc-font-size--desktop vs --doc-font-size. To get the font slightly larger for code perhaps the ratio can be changed on line 135 and 140.
|
@jyotiattri can you take the review into consideration, are you still working on this? |
|
Yes, I am working on the suggested changes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fix for Text too small to read (21 pages) from Mobile usability issues reported in Google search console
cc: @zregvart