Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-14732: Position footer to be fixed on the bottom of the screen #266

Merged
merged 1 commit into from
Mar 26, 2020
Merged

CAMEL-14732: Position footer to be fixed on the bottom of the screen #266

merged 1 commit into from
Mar 26, 2020

Conversation

AemieJ
Copy link
Contributor

@AemieJ AemieJ commented Mar 24, 2020

  • It has been observed that for certain pages where the content is minimal, the footer is not fixed to the bottom of the page in the desktop version.

  • Thus, I changed the code such that the footer will remain on the bottom of the page regardless of the minimal text on each webpage.

BEFORE

before

AFTER

after

zregvart
zregvart approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be okay, I need to check on the preview.

@zregvart
Copy link
Member

Preview is here.

@zregvart zregvart merged commit 1259ec6 into apache:master Mar 26, 2020
@zregvart
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zregvart zregvart zregvart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AemieJ @zregvart