Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-15140: Improve Mobile Main-Menu #451

Closed

Conversation

aashnajena
Copy link
Contributor

In this PR I have :

  • Removed the "About" menu-item from the header, because it now present in the footer
  • Changed header.hbs and header.html layout files to remove code for sub-menus
  • Removed styling for submenus (.navbar-dropdown class is no longer required)
  • Changed the design of the main menu on smaller screens as discussed on the JIRA issue.

Here's how it looks for smaller screens in landscape and portrait mode respectively :

image

image

@AemieJ
Copy link
Contributor

AemieJ commented Aug 6, 2020

@aashnajena PR #448 deals with those changes along with the desktop version as well.

@aashnajena
Copy link
Contributor Author

Thanks for pointing out, I didn't realise you're working on this issue. Please link it to the JIRA issue so that it's easier to track. Since I've already implemented it now, maybe we can take some implementation bits from here and use them eg. the images, the resizable menu (so that it doesn't go to scroll even if orientation is landscape), the dynamic sizes of menu-items which change with height & width of screen, and having paths of logo-images as part of config.toml, so that they are easy to map, if we want to change the images.

@zregvart
Copy link
Member

@aashnajena having merged #448, is there something that we miss from this or can this PR be closed?

@aashnajena
Copy link
Contributor Author

This can be closed now

@aashnajena aashnajena closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants