CAMEL-15392: documentation and community redesign #471
Conversation
|
This is an issue within the documentation page for the certain screen width. |
|
I personally find the structure of the documentation page within the desktop screen version quite disorientated and unstructured. I would prefer it if the images were on the same side as presented as on the community page, looks neater. Also, I observed that due to one image for camel-core the context isn't aligned with the contents of the sub-project. I find the following structure much neater: |
| display: inline-block; | ||
| box-shadow: 0 4px #8e480b; | ||
| font-weight: bold; | ||
| padding: 0.4rem 1rem; |
There was a problem hiding this comment.
| padding: 0.4rem 1rem; | |
| padding: 0.4rem 1rem; | |
| line-height: 2.5rem; |
There was a problem hiding this comment.
When exactly are you observing the overlap? I have already provided line-height for <1024px screens (line 355) to avoid the overlap, and I can't see the buttons overlapping for any screen width.
There was a problem hiding this comment.
This overlapping is observed for 1024px as well.
There was a problem hiding this comment.
My view at 1024px 100% zoom
|
@AemieJ The camel core context is not aligned with the rest because there's only one icon present, and if we give it 30% width, it leaves a lot of blank space which looks bad. Since the alignments are alternating, it's not a noticeable flaw. I did think about making them all left-aligned, but it looks very odd to have one icon for camel core and two for the rest. If we can use just one icon for each sub-project, the left-alignment will look good. |
|
@aashnajena I hear you but I respectfully disagree with you. In my opinion, altering a few lines of CSS and making it look structured and consistent through gives a neater effect to the design be it 1 or 2 images. |
antora-ui-camel/src/css/docs.css
Outdated
| .docs .box .content, | ||
| .community .box .content, | ||
| .docs .box .icon, | ||
| .community .box .icon { |
There was a problem hiding this comment.
Missed out on these rules earlier
| .community .box .icon { | |
| .community .box .icon, | |
| .docs .box.camel-core .content, | |
| .docs .box.camel-core .icon { |
| display: inline-block; | ||
| box-shadow: 0 4px #8e480b; | ||
| font-weight: bold; | ||
| padding: 0.4rem 1rem; |
There was a problem hiding this comment.
My view at 1024px 100% zoom
zregvart
force-pushed
the
pr/docs-layout
branch
from
52cf138
to
e3cae7f
Compare
|
@zregvart can we fix and merge this? The website still shows underlines under images and I think this PR fixes that as well |
|
@aashnajena thanks for the ping. I'll rebase and merge this later today. |
|
I'm rather tied up with other tasks, so I didn't have the time to look at this yesterday, I'll try to find some time today. |
Based on pull request #469 by @aashnajena, rebased with fixed links.
zregvart
force-pushed
the
pr/docs-layout
branch
from
e3cae7f
to
9e20d8e
Compare
|
This is now merged thanks @aashnajena and @AemieJ. I'm sure we'll find other issues to improve, feel free to raise issues or create additional PRs for them. |
Based on pull request #469 by @aashnajena, rebased with fixed links.