Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-19359: camel-spring - Graceful shutdown in Spring Boot better s… #10184

Merged
merged 2 commits into from
May 23, 2023

Conversation

davsclaus
Copy link
Contributor

…upported. Changed the shutdown phase in SpringCamelContext to be a bit later.

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

…upported. Changed the shutdown phase in SpringCamelContext to be a bit later.
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
1 1 0 1

@davsclaus
Copy link
Contributor Author

I would like to test a bit more if 65537 is too much, the core services in SB are using - 1024 and -2048, there may be some stuff that are closer to these numbers that we need Camel to stop beforehand.

…upported. Changed the shutdown phase in SpringCamelContext to be a bit later.
@github-actions
Copy link
Contributor

Components tested:

Total Tested Failed ❌ Passed ✅
2 2 0 2

@davsclaus davsclaus merged commit 1221982 into main May 23, 2023
4 checks passed
@davsclaus davsclaus deleted the sb-graceful branch May 23, 2023 04:24
davsclaus added a commit that referenced this pull request May 23, 2023
#10184)

* CAMEL-19359: camel-spring - Graceful shutdown in Spring Boot better supported. Changed the shutdown phase in SpringCamelContext to be a bit later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants