-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAMEL-19456] The invocation of the removeRoute() method is too slow … #10399
Conversation
…when using RAW().
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run. 🤖 Use the command If necessary Apache Camel Committers may access logs and test results in the job summaries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor findings.
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
Outdated
Show resolved
Hide resolved
core/camel-util/src/main/java/org/apache/camel/util/UnsafeUriCharactersDecoder.java
Outdated
Show resolved
Hide resolved
Components test results:
|
Core test results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Performance changes are always interesting.
I am requesting just a minor set of fixes.
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
Outdated
Show resolved
Hide resolved
core/camel-util/src/main/java/org/apache/camel/util/UnsafeUriCharactersDecoder.java
Outdated
Show resolved
Hide resolved
Also, out of curiosity: do you have any numbers? A JMH test, maybe? |
I apologize, but I am currently in the process of making some changes to the code. I will commit it again after the modifications are complete. |
No worries, we are happy to receive contributions! Looking forward to the updated one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the changes. There's one problem with star imports, but I am fine with the rest of the approach.
So, please, just adjust the star imports I mentioned and, IMHO, it should be good to go.
core/camel-util/src/main/java/org/apache/camel/util/URISupport.java
Outdated
Show resolved
Hide resolved
Components test results:
|
Core test results:
|
Components test results:
|
Core test results:
|
Components test results:
|
Core test results:
|
Unfortunately, the tests keep failing, so I decided to check the main branch without making any modifications, and it turns out that an error occurs in camel-core. [ERROR] Failures: [INFO] Camel :: Core ...................................... FAILURE [03:47 min] @orpiske |
@Luke-hbk yes, I will take a look today. |
Let's get this one in. It would be good to have some tests for it on the CI. Merging ... |
Thanks for your contribution @Luke-hbk |
…when using RAW().
Description
Working on that issue about "The invocation of the removeRoute() method is too slow when using RAW()."
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck