Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for character escape handling #1109

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1,30 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.camel.converter.jaxb;

/**
* Constants used by Camel Jaxb module
*
* @author Siddharth Sharma
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove author tag from source code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Learning about OSS best practices. Thanks!

* @since Aug 4, 2016
*
*/
public interface JaxbConstants {

String JAXB_ESCAPE_HANDLER = "CamelJaxbCharacterEscapeHandler";

}
Expand Up @@ -64,6 +64,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import com.sun.xml.bind.marshaller.CharacterEscapeHandler;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot have dependency on com.sun classes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Sorry, wasn't aware of the dependency constraint. I've updated the PR and made it generic to inject any properties for a given JAXB-RI


/**
* A <a href="http://camel.apache.org/data-format.html">data format</a> ({@link DataFormat})
* using JAXB2 to marshal to and from XML
Expand Down Expand Up @@ -101,6 +103,7 @@ public class JaxbDataFormat extends ServiceSupport implements DataFormat, DataFo
private JaxbXmlStreamWriterWrapper xmlStreamWriterWrapper;
private TypeConverter typeConverter;
private Schema cachedSchema;
private CharacterEscapeHandler escapeHandler;

public JaxbDataFormat() {
}
Expand Down Expand Up @@ -146,6 +149,13 @@ public void marshal(Exchange exchange, Object graph, OutputStream stream) throws
if (namespacePrefixMapper != null) {
marshaller.setProperty(namespacePrefixMapper.getRegistrationKey(), namespacePrefixMapper);
}
CharacterEscapeHandler escapeHandlerObject = exchange.getProperty(JaxbConstants.JAXB_ESCAPE_HANDLER, CharacterEscapeHandler.class);
if(escapeHandlerObject == null) {
escapeHandlerObject = getEscapeHandler();
}
if(escapeHandlerObject != null) {
marshaller.setProperty(CharacterEscapeHandler.class.getName(),escapeHandlerObject);
}

marshal(exchange, graph, stream, marshaller);

Expand Down Expand Up @@ -536,4 +546,12 @@ private void returnSchemaFactory(SchemaFactory factory) {
SCHEMA_FACTORY_POOL.offer(factory);
}
}

public CharacterEscapeHandler getEscapeHandler() {
return escapeHandler;
}

public void setEscapeHandler(CharacterEscapeHandler escapeHandler) {
this.escapeHandler = escapeHandler;
}
}