Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-17027 stream into buffer of configured size #11153

Merged

Conversation

jono-morris
Copy link
Contributor

Read the message body in chunks instead of reading the entire body into memory to better handle large payloads.

Introduced a new option 'buffersize' that controls how much of the message body is read for a single chunk with a default size set to 1000000, which is the same as the batchsize meaning that one chunk will be uploaded as one part.

Further PR to follow to address class thread-safety.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I would like to have a deeper look this week. So wait for me, before merging

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No need to wait.

@davsclaus davsclaus merged commit c4903cd into apache:main Aug 21, 2023
3 checks passed
@jono-morris jono-morris deleted the CAMEL-17027_avoid_streaming_into_memory branch August 26, 2023 12:39
@jono-morris jono-morris restored the CAMEL-17027_avoid_streaming_into_memory branch August 26, 2023 12:49
@jono-morris jono-morris deleted the CAMEL-17027_avoid_streaming_into_memory branch August 26, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants