-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-19970 - Avoid IllegalArgumentException for file without #11678
CAMEL-19970 - Avoid IllegalArgumentException for file without #11678
Conversation
not found a way to write a test easily. |
Given that it is a regression in Camel 3.21, I think we should backport it to 4.0.x and 3.21.x and 3.x if and when the PR is accepted |
6b3b169
to
b091336
Compare
b091336
to
263ad76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done in the skipFile method instead, and I think its easier to just check if there is no file extension then return true to skip the file.
263ad76
to
fbaf184
Compare
Ah can you move that logic after the // skip dirs check as essentially almost all dirs are named without a dot / extension. |
fbaf184
to
9fc7789
Compare
extension in same folder when using JBang and that we let auto-detect routes, the files without extensions were added as potential routes and, as expected, no RouteLoader were found. An IllegalArgumentExeption was thrown at this time. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
9fc7789
to
d5acbc8
Compare
extension in same folder
when using JBang and that we let auto-detect routes, the files without extensions were added as potential routes and, as expected, no RouteLoader were found. An IllegalArgumentExeption was thrown at this time.
Note that the regression is a side effect. Previously it was part of Routes but there wasn't
pre-parsing
and so there was no error (at least when doing an export)Description
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTests
locally and I have committed all auto-generated changes