CAMEL-20010

[brunomendola]

Description

Preserve default queries in JdbcMessageIdRepository to avoid replacing the table name more than once.

Solves CAMEL-20010.

Target

• I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

• If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

• I checked that each commit in the pull request has a meaningful subject line and body.

• I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[essobedo]

I'm wondering if it is normal that the JdbcMessageIdRepository is initialized several times which is maybe more the problem to fix, WDYT?

[davsclaus]

doInit ensures its only invoked once

[essobedo]

doInit ensures its only invoked once

So why do we get what is described in the ticket? I quote:

JdbcMessageIdRepository is designed to replace the CAMEL_MESSAGEPROCESSED substring in the queries with the custom table name in the onInit() function, but looks like this function is called multiple times and it keeps replacing the substring that is present also in the custom table name.

If I understand it well, if onInit() was called only once as it should, the problem would not occur

[brunomendola]

doInit ensures its only invoked once

...

If I understand it well, if onInit() was called only once as it should, the problem would not occur

I think @essobedo has a point.

I mean... the replacement was clearly happening twice, but the onInit() function should not be invoked twice by Camel.

Maybe it's something related to some particular condition?
The fact that the idempotentRepository was a bean, could it produce some unexpected behavior? Maybe something about concurrency? Is the onInit() call synchronized in some way?