New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-10222: Conflicts-free springboot BOM #1182
Conversation
Yeah this is great work @nicolaferraro. Have you tried updating the spring boot examples we have in examples to use the -starter modules? IMHO we should use this ourselves there also. We could also consider having a readme.adoc file in the components-starter directory that explains a bit about that this is Spring Boot components. And that the following are not supported, and then list the few ones that do not work. |
Yeah, sure! I can do it. Also the bom needs a bit of documentation. |
I checked the examples and changed the ones that were not using starters. They work! I also added some docs to the |
+1 Lovely work @nicolaferraro |
Great work! Thanks a lot @nicolaferraro ! |
Ah Dhiraj just merged to master some massive code changes in the generated source code. I think you would need to rebase before you can merge this. |
Yeah, np. I'm about to do it. |
Trying to run a full build. Am I losing something? |
My mistake. Forgive me :-) |
CAMEL-14173: camel-paho - Do not unsubscribe for durable topics when …
I created a camel BOM without conflicts with the spring-boot one, as discussed in the mailing list.
I removed the following modules from the list of starters (with reference to the previous PR):
There are also other (10) modules having some problems, but issues might be caused by the testing environment. For example, the Cassandra module might work with v2 of the driver, but the tests cannot ensure this because unit tests include cassandra-all into the classpath and it is much more probable that cassandra-all cannot work in a spring-boot environment (and it must not).
I kept that starters, as they should work: Ahc, Cassandra, Consul, Jgroups, Jibx, Jpa, Xmljson, Mongodb, MongodbGridfs, Mybatis.
Waiting for feedbacks.