Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20019: demo session handler implementation #12530

Conversation

jono-morris
Copy link
Contributor

Description

Draft code demonstrating a Vertx server handler implementation that manages server-side sessions and session cookie handling.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jono-morris
Copy link
Contributor Author

Wondering whether this approach is what you're thinking in relation to this ticket, or whether you're hoping fore a more general cookie handler where cookies can be added/removed per route. The producer cookie handlers I found looked like they were for session handling.

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this needs further review

components/camel-platform-http-vertx/pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah a good start, this is vertx specific which of course works great as its vertx based.
Adding that camel cookie stuff is something you can look at after getting this vertx stuff implemented.
Also remember to add something into the docs, see src/main/docs folder

components/camel-platform-http-vertx/pom.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the docs label Dec 24, 2023
@jono-morris jono-morris marked this pull request as ready for review December 24, 2023 12:56
@jono-morris jono-morris merged commit f79496b into apache:main Dec 27, 2023
3 checks passed
@jono-morris jono-morris deleted the CAMEL-20019_platform-http-vertx_add_cookie_support branch January 24, 2024 07:38
ryan-highley pushed a commit to ryan-highley/camel that referenced this pull request Apr 8, 2024
…che#12530)

* CAMEL-20019: demo session handler implementation

* CAMEL-20019: updates in response to review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants