CAMEL-10178: Google PubSub Component #1267
Conversation
| * PubSub Endpoint Definition | ||
| */ | ||
| @UriEndpoint(scheme = "google-pubsub", title = "Google Pubsub", | ||
| syntax = "google-pubsub:projectId:destinationName?[options]", label = "messaging") |
There was a problem hiding this comment.
The syntax should be without [options]. Those are implied.
| @UriParam(name = "loggerId", description = "Logger ID to use when a match to the parent route required") | ||
| private String loggerId; | ||
|
|
||
| @UriParam(name = "concurrentConsumers", description = "The number of parallel streams consuming from the subscription") |
There was a problem hiding this comment.
You need to set defaultValue in the @UriParam to 1 so its the same as the field value
There was a problem hiding this comment.
Done for both params.
| @UriParam(name = "connectionFactory", description = "ConnectionFactory to obtain connection to PubSub Service. If non provided the default one will be used") | ||
| private GooglePubsubConnectionFactory connectionFactory; | ||
|
|
||
| @UriParam(defaultValue = "AUTO", enums = "AUTO, NONE", |
There was a problem hiding this comment.
There should not be space in the enums attribute, eg AUTO,NONE
|
@davsclaus Once again - thank you. Anything else? |
|
Seems good. I think @oscerd and others have helped you review recently. So I will let them merge the PR. |
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Ah yeah javadoc on endpoint become the component description AFAIR in the generated docs. So please updated this. eg its used for the description summary at https://github.com/apache/camel/tree/master/components#components
There was a problem hiding this comment.
Gladly. What would the component to demonstrate a good example of such doco?
There was a problem hiding this comment.
|
Thanks the PR has been merged. I had to fix a little thing here: Can you close the PR? Many thanks! |
ENTESB-12630 - Upgrade Infinispan to version 9.4.16.Final-redhat-00003
Google PubSub component with producer and consumer endpoints, unit and integration tests.