Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20019: add platform http vertx cookie handler #13301

Conversation

jono-morris
Copy link
Contributor

Description

A simple cookie handler that allows cookie addition, retrieval and expiry/removal.

Using the cookieJar that is available via the Vertx routing-context seemed to the be simplest implementation, and add/remove/get cookie operations delegate to the request/response Vertx objects.

Get/Remove operations on the CookieHandler return String values as opposed to Cookies to abstract away from specific Cookie implementations

The cookie handler is made available to routes as the 'COOKIE_HANDLER' exchange property.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jono-morris
Copy link
Contributor Author

@davsclaus, were you thinking of something along these lines for the Vertx cookie hander?

@davsclaus
Copy link
Contributor

Yes that is really good.

@github-actions github-actions bot added the docs label Feb 27, 2024
@jono-morris jono-morris marked this pull request as ready for review February 27, 2024 11:56
@jono-morris jono-morris merged commit 687bc20 into apache:main Feb 27, 2024
3 checks passed
@jono-morris jono-morris deleted the CAMEL-20019_add_platform-http-vertx_cookie_handler branch February 27, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants