Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-10543: New logo #1369

Closed
wants to merge 3 commits into from
Closed

CAMEL-10543: New logo #1369

wants to merge 3 commits into from

Conversation

lanwen
Copy link
Contributor

@lanwen lanwen commented Jan 1, 2017

image

@davsclaus
Copy link
Contributor

Thanks for the logo submission.

@davsclaus
Copy link
Contributor

The logo can be viewed by clicking the PR
d0e6410

And then click the view button for those 2 files.

@oscerd
Copy link
Contributor

oscerd commented Jan 2, 2017

I like it :-)

@davsclaus
Copy link
Contributor

Thanks @lanwen for the logo proposal.

Have patience as we are a bit slow after new year and have to get the logo procedure up to speed again.

I wonder if the Camel animal can also be made as a little icon? Maybe in an alternative color. I am asking because we have some tooling where we use this animal: https://github.com/davsclaus/camel-idea-plugin/tree/master/src/main/resources/icons

But if we could get icons of your shape then that would be really nice if this logo becomes the new logo.

@in1t5
Copy link

in1t5 commented Jan 6, 2017

@lanwen tremendous work!

@lanwen
Copy link
Contributor Author

lanwen commented Jan 6, 2017

@davsclaus To be clear - as i understand, you want to add also icons that can be used in case:
image
(only as animal)

Or you want to change my variant that can be used as icons too?

Will be svg enough or it needs also png?

@davsclaus
Copy link
Contributor

@lanwen yes I would like to use your animal in that tooling, eg in that gutter.

A svg is preferred as then we can scale the image to our needs. Sometimes you need tiny 16x16 icons. Other times its 48x48. Or sometimes you let it use a svg and the system can auto scale to best display.

Also it could be good to have the animal flipped so you can have it look either left or right.
I am thinking about showing a right faced icon for incoming routes, and left faced icon for outgoing.

@lanwen
Copy link
Contributor Author

lanwen commented Jan 8, 2017

updated, please take a look

@davsclaus
Copy link
Contributor

IDEA have different themes so you can use the dark theme or the regular white theme. I am using the white currently - so I wonder if the Camel animal is "too white" so the animal/icon is hardly visible?

I wonder if the color of the animal should be a different color?

There is a screenshot here with the old Camel animal in the gutter when using the regular theme of IDEA
https://github.com/davsclaus/camel-idea-plugin/blob/master/img/09-camel-gutter.png

@lanwen
Copy link
Contributor Author

lanwen commented Jan 9, 2017

yep, that's why it has dark square as background now. Maybe i can try to compile plugin by myself to try this image in a few days

@davsclaus
Copy link
Contributor

Oh sure you are very welcome to try build the plugin. There should be instructions on the readme file how to do that.

Mind that an IDEA plugin development does take a little bit extra to setup than to just load any maven project.

The icons are in the icons folder.
https://github.com/davsclaus/camel-idea-plugin/tree/master/camel-idea-plugin/src/main/resources/icons

I logged a ticket about the possibility to have a way to switch between icons in the plugin
camel-tooling/camel-idea-plugin#137

@davsclaus
Copy link
Contributor

@lanwen I am adding support for loading custom icon into the IDEA plugin which you setup from its preference. Then you can load a PNG file from your local file system.

I converted the svg to png and resized it as 16x16. It might look better in a bit higher scale or maybe using a better tool to convert/resize etc. I am not a professional in graphics.

However it looks nice with the alternative icon.

custom-icon

I think it can give room for trying out different color combinations of the logo. For example I wonder if the animal can be non white, or if the shield could maybe use a different color?

What if the animal is the orange color, and the shield is greyish?

@davsclaus
Copy link
Contributor

And with darcula as theme

custom-icon-darcula

@davsclaus
Copy link
Contributor

@lanwen there is a new release of the camel idea plugin which comes with your icon as well which you can choose from the preference. You can also load a custom png file as icon as well, so you can use that to check how changes to the logo/icon looks in the editor etc.

@lanwen
Copy link
Contributor Author

lanwen commented Jan 16, 2017

thanks! Have no time to try on past weekend, but hope find some time soon

@lanwen
Copy link
Contributor Author

lanwen commented Jan 16, 2017

Hmm, any 16x16 pic looks ugly and pixeled

image

especially on mac with retina :(

but i can't insert svg as is - it transforms to 1x1 pic. Can it be pasted as svg? It can simplify tests.

@davsclaus
Copy link
Contributor

davsclaus commented Jan 16, 2017

IDEA uses icon files in .ico format. If that is better we can likely make the plugin accept both .png and .ico files, or only .ico etc.

I can try to take a 2nd look if there is something that springs to mind about other formats. But the java type it uses is a java swing icon: https://docs.oracle.com/javase/7/docs/api/javax/swing/Icon.html

@lanwen
Copy link
Contributor Author

lanwen commented Jan 17, 2017

@davsclaus
Copy link
Contributor

Ah nice - then we would need retina versions of those icons so they can look nice there too

@davsclaus
Copy link
Contributor

@lanwen I wonder if you could try the 0.3.5 release of IDEA plugin as it has retina icons included, to see if they look okay on your computer?

@lanwen
Copy link
Contributor Author

lanwen commented Jan 23, 2017

They looks better! So now i know how to test my images, thx. But still have no time to finish it :( Will try to find some time!

@lanwen
Copy link
Contributor Author

lanwen commented Jan 29, 2017

M?
image

image

cam
cam 2x

@davsclaus
Copy link
Contributor

Thanks for the blue Camel.

The retina looks much better. However I personally don't like the blue color of the Camel. I may be too traditional and like the orange color, or maybe some grey/lighter color.

@lanwen
Copy link
Contributor Author

lanwen commented Jan 31, 2017

Here some color tries (i can try more if you want to see smth else)

9e9e9e

image
image
1cam
1cam 2x

most neutral


ff9900

image

image

2cam
2cam 2x

too bright, i think


ba6500

image

image

3cam
3cam 2x

my favorite


990000

image

image

4cam
4cam 2x

(looks strange but for example of dark-red)


141414 /cccccc

image
image
5cam_dark
5cam
5cam 2x_dark
5cam 2x

Different for dark/light theme

@davsclaus
Copy link
Contributor

I like your favorite as well, which is the darker orange color ba6500

@Magamir
Copy link

Magamir commented Jan 31, 2017

I'd also vote for ba6500 - this looks the most like native camels.

@oscerd
Copy link
Contributor

oscerd commented Jan 31, 2017

I prefer the darker orange too.

@hanusto
Copy link

hanusto commented Jan 31, 2017

I prefer ba6500 too.

@lanwen
Copy link
Contributor Author

lanwen commented Jan 31, 2017

added svg and png images

@onderson
Copy link
Contributor

+1 -> ba6500

@davsclaus
Copy link
Contributor

@lanwen thanks, I have updated the Camel IDEA plugin with your new png icons.

@lanwen
Copy link
Contributor Author

lanwen commented Jan 31, 2017

Perfect! What will be the proposals about logo?

@davsclaus
Copy link
Contributor

@lanwen

We have not forgotten you. The logo procedure is in motion but I think we should find the time to put our details to the community about a deadline for proposals so we wont drag this out forever.

I wonder if we can align the color of the Camel in the logo with the badge and the animal itself, eg people seems to favor color ba6500 the most. But that seems to be the same color as the badge itself with the white Camel. What if the animal was colored ba6500 in that logo as well and the badge had another color? However I do like how the white and black border make the logo stand out.

@davsclaus
Copy link
Contributor

Just a heads up that the procedure is up an running
http://camel.apache.org/2017/02/28/new-apache-camel-logo-open-for-proposals.html

@zregvart
Copy link
Member

zregvart commented May 8, 2017

Hi we are voting on the received proposals, the vote is open till 15.5. see all the proposals and cast the vote for the three designs you prefer the most.
Also read the news announcement on Camel blog.

@oscerd
Copy link
Contributor

oscerd commented Dec 7, 2017

Since the vote ended I'm closing the related PRs

@oscerd oscerd closed this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants