-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-20822: Implement OpenAI Tool Capabilities natively in Camel #14296
Conversation
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For multiple parameters, then Camel has support for this with multiValue options. This may be a nicer approach as you can then just do
parameter.foo=123¶meter.bar=true
parameterType.foo=integer¶meterType.bar=boolean
The type could maybe also be defined in the value itself
parameter.foo=integer:123¶meter.bar=boolean:true
...-chat/src/main/java/org/apache/camel/component/langchain4j/chat/LangChain4jChatEndpoint.java
Outdated
Show resolved
Hide resolved
...-chat/src/main/java/org/apache/camel/component/langchain4j/chat/LangChain4jChatEndpoint.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm nitpicking a bit with the documentation.
Overall, it looks promising!
components/camel-ai/camel-langchain4j-chat/src/main/docs/langchain4j-chat-component.adoc
Outdated
Show resolved
Hide resolved
components/camel-ai/camel-langchain4j-chat/src/main/docs/langchain4j-chat-component.adoc
Outdated
Show resolved
Hide resolved
Oh nice, I'll add multiValued options, thanks! |
Description
Target
camel-3.x
, whereas Camel 4 uses themain
branch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTests
locally and I have committed all auto-generated changes