Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20822: Implement OpenAI Tool Capabilities natively in Camel #14296

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

Croway
Copy link
Contributor

@Croway Croway commented May 31, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@Croway Croway requested a review from zbendhiba May 31, 2024 16:37
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multiple parameters, then Camel has support for this with multiValue options. This may be a nicer approach as you can then just do

parameter.foo=123&parameter.bar=true
parameterType.foo=integer&parameterType.bar=boolean

The type could maybe also be defined in the value itself

parameter.foo=integer:123&parameter.bar=boolean:true

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nitpicking a bit with the documentation.

Overall, it looks promising!

@Croway
Copy link
Contributor Author

Croway commented Jun 3, 2024

For multiple parameters, then Camel has support for this with multiValue options. This may be a nicer approach as you can then just do

parameter.foo=123&parameter.bar=true parameterType.foo=integer&parameterType.bar=boolean

The type could maybe also be defined in the value itself

parameter.foo=integer:123&parameter.bar=boolean:true

Oh nice, I'll add multiValued options, thanks!

@Croway Croway merged commit ca1da6a into apache:main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants