Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20833 Add a recursive option for polling files and subdirectories #14374

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

cunningt
Copy link
Contributor

@cunningt cunningt commented Jun 4, 2024

Description

Target

  • [x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • [x ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • [x ] I checked that each commit in the pull request has a meaningful subject line and body.
  • [x ] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@cunningt cunningt requested a review from orpiske June 4, 2024 19:03
Copy link
Contributor

github-actions bot commented Jun 4, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this, @cunningt ! LGTM.

Just fix the item pointed by Claus and it should be good to merge.

@davsclaus
Copy link
Contributor

@cunningt did you get a chance to update this PR

@cunningt
Copy link
Contributor Author

cunningt commented Jun 7, 2024

Sorry about that! Removed the default value for the path, added a null check on path.

@davsclaus davsclaus merged commit b223254 into apache:main Jun 10, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants