Replace the Number.valueOf method with the Number.parseXXX method. #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more efficient to use the static parseXXX method to extract unboxed primitive value from a String. http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING
Contributor
|
Thanks @brucekuiliu, PR merged. |
Contributor
Author
|
@aldettinger I didn't close it, but it is a closed request. And there is no close button on my interface. |
Contributor
|
Yeah, I've seen this and edited my message afterward. This was my first
merge as a committer, so you've seen a small hiccup ;)
Keep up with the findbugs investigation.
…On Fri, Oct 13, 2017 at 11:05 PM, BruceKuiLiu ***@***.***> wrote:
@aldettinger <https://github.com/aldettinger> I didn't close it, but it
is a closed request. And there is no close button on my interface.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2038 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVIAtbn1Sdch6EY_FlJaDe6JNUxc6t5xks5sr9CKgaJpZM4P4t9r>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more efficient to use the static parseXXX method to extract unboxed primitive value from a String.
http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING