Adds zipkin http transport and moves off deprecated collector #2151
Conversation
|
This came out of a request by @TimurShakirov |
|
Thanks a lot. I think I spotted a new source file which did not have the ASF license header. |
|
ok all the headers and import related distractions should be gone now |
|
Thanks @adriancole have you btw had any chance to try to example/camel-example-zipkin with these new changes and see if that example still works. And maybe that example needs some updates as well? However this work looks great and we will surely merge it. Thanks for the contribution. |
|
Thanks for the kind words. I haven't tried the example, yet, but surely
should. I'll report back tomorrow.
PS I think we can probably do a little more in the unit tests, for example,
checking the spans made sense.
I'll timebox some effort towards that, too.
|
This allows you to use zipkin's http endpoint, and any modern transport. This is important as scribe is deprecated. Notably, this doesn't change internal plumbing to use new Brave Tracer api, though that can be done in a later change.
|
ok examples work, but I'm not sure of the data. Going to compare vs the old one |
|
OK the data matches the old version. I think there is some follow-up work to do around modeling, which hasn't to do with this change, but should be done. That said, I have to budget time to work through that later as I have to round-robin through other project maintenance. PS @davsclaus if you are up to it we have a meeting in may (obv we can work through things prior) https://docs.google.com/document/d/1u5sKZkhLux10bEZuXMhYILkigBtx4vIgfr1WRLq3ZfY/edit?ts=5a329ada#heading=h.siw588q01xt9 |
|
@adriancole thanks merging this, but the OSGi stuff dont work. If we had a $ for every time a JAR had problems with its OSGi MANIFEST.MF we would be rich. You can run this tests in And then fiddle with the We will have to disable it and log a JIRA. |
|
ok, so just to be clear. this is merged, but OSGi is not quite there.. so
if I get that working all good?
|
|
Yes thanks @adriancole And thanks for the heads-up on that meeting. I dont know my calendar at that time in 2018. |
This fixes packaging where zipkin2 types were in the zipkin 1 jar. It also restores the missing MANIFEST.MF file needed for OSGi to work properly. See apache/camel#2151
This fixes packaging where zipkin2 types were in the zipkin 1 jar. It also restores the missing MANIFEST.MF file needed for OSGi to work properly. See apache/camel#2151
This removes the need to share internal packages between the brave 3 and 4 apis and zipkin. In doing so, it unlocks some OSGi problems. This also makes it easier to transition to zipkin2 by allowing reporter2 as a Brave.Builder.spanReporter arg. See apache/camel#2151
This removes the need to share internal packages between the brave 3 and 4 apis and zipkin. In doing so, it unlocks some OSGi problems. This also makes it easier to transition to zipkin2 by allowing reporter2 as a Brave.Builder.spanReporter arg. See apache/camel#2151
This fixes packaging where zipkin2 types were in the zipkin 1 jar. It also restores the missing MANIFEST.MF file needed for OSGi to work properly. See apache/camel#2151
This removes the need to share internal packages between the brave 3 and 4 apis and zipkin. In doing so, it unlocks some OSGi problems. This also makes it easier to transition to zipkin2 by allowing reporter2 as a Brave.Builder.spanReporter arg. See apache/camel#2151
This allows you to use zipkin's http endpoint, and any modern transport.
This is important as scribe is deprecated. Notably, this doesn't change
internal plumbing to use new Brave Tracer api, though that can be done
in a later change.