CAMEL-5558 - add file existing move strategy interface to let custom #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementations be provided and add a test case for file component
oscerd
approved these changes
Oct 1, 2018
There was a problem hiding this comment.
LGTM, I'd like to have the feedback from @davsclaus too :-)
|
LGTM. The interface for the file exist move strategy would be good to have its method and parameters javadoc'ed as that is what end users can implement for custom strategy. Does camel-jsch component compile and test with this as its AFAIR also extends the file component. |
|
I had a similar requirement. I implemented and tested with file component and naturally ftp component. Have not checked upon jsch. I will look into and improve javadoc. Thanks for reviewing |
|
Javadoc improved and no affect on jsch. |
davsclaus
approved these changes
Oct 2, 2018
|
I'll merge this today. |
oscerd
approved these changes
Oct 2, 2018
|
Thanks @onderson |
|
Merged on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementations be provided and add a test case for file component