[CAMEL-13076] ObjectHelper does no longer see META-INF/services from … #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
LGTM, I'd like to have the feedback of @gnodet and @davsclaus too.. Can you run mvn -Psourcecheck to fix CS? Thanks a lot!
davsclaus
approved these changes
Jan 18, 2019
|
|
||
| return in; | ||
| try { | ||
| URL res = loadResourceAsURL(name); |
There was a problem hiding this comment.
I looked into the JDK source and its loadResourceAsStream does the same here to load via URL first and then open its stream. So we can safely do this also in Camel.
|
Yeah need CS fixes. With this change with TCCL etc we need just to be aware/remember this for OSGi tests when we get them working on master that it can also work there - eg OSGi classloading is also complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…camel-core