New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAMEL-13747: Added basic auth support to camel-solr #3034
Conversation
Ah well it was never implemented on ConcurrentUpdateSolrClient |
Can you please raise also a issue here? https://issues.apache.org/jira/projects/CAMEL so we can track it better? |
Yes of course, just created. |
And can you please open this against master branch and against camel-2.x? 2.24.x is already out and there is already 2.24.1. This is a new feature, so it should be part of camel-2.25.0. Thanks. You can close this PR and open another one against camel-2.x or closing this once you'll open the new one. |
Sure, changed this PR against master do you want me to create another PR against camel-2.x? |
Yes. Please |
Oki before that if you can review I have a small issue. I enabled basic auth for all tests so the feature can be tested along with all available methods but right now streaming tests are failing because of ConcurrentUpdateSolrClient does not implement it at all. Setting |
I think it makes sense to set blockUnknown to false for tests purpose |
Alright changed it that way. |
Another thing occurred to me. Currently we use this component on production and input body comes as |
It could be part of another issue and another PR. Thanks |
Alright then. |
Thanks, merged on master |
This is an attempt of implementing basic auth on solr component according to recommended way mentioned here. Concurrent client seems to be failing though for some reason when basic auth is enabled.