[CAMEL-14096] Adding Kudu component. #3272
Conversation
|
@oscerd master is 3.x, right? I was going to work on some 3 branch once this is approved. |
|
yes |
components/camel-kudu/pom.xml
Outdated
| <schemeName>kudu</schemeName> | ||
| <componentName>Apache Kudu</componentName> | ||
| <componentPackage>org.apache.camel.component.kudu</componentPackage> | ||
| <kuduVersion>1.10.0</kuduVersion> |
There was a problem hiding this comment.
please add this properties under parent/pom
components/camel-kudu/pom.xml
Outdated
| <componentName>Apache Kudu</componentName> | ||
| <componentPackage>org.apache.camel.component.kudu</componentPackage> | ||
| <kuduVersion>1.10.0</kuduVersion> | ||
| <slf4jVersion>1.7.25</slf4jVersion> |
There was a problem hiding this comment.
This can be removed I guess
| * <a href="https://kudu.apache.org/">Apache Kudu</a>, a free and open source | ||
| * column-oriented data store of the Apache Hadoop ecosystem. | ||
| */ | ||
| @UriEndpoint(firstVersion = "2.23.0", |
There was a problem hiding this comment.
First version shoud be 2.25.0
| /** | ||
| * Set the client to connect to a kudu resource | ||
| * | ||
| * @param kuduClient |
There was a problem hiding this comment.
all the @param annotations can be removed
| String key = (String) entry.getKey(); | ||
| Object value = entry.getValue(); | ||
| switch (value.getClass().toString()) { | ||
| case "class java.lang.String": |
There was a problem hiding this comment.
Isn't a better way to express this, it's really ugly :-(
There was a problem hiding this comment.
I thought the same when I saw it :) Will look for something better. It looks like a list of if-elses with instanceof is an antipattern.
| @@ -0,0 +1,104 @@ | |||
| { | |||
There was a problem hiding this comment.
This is not useful for camel and it can be removed. Please have a look at the other component structure.
|
Thank you! |
|
By the way I would first add this to master. I'm not sure this is really needed on 2.x, since we're moving to camel 3 |
|
Ok, I can move and work on master. Will take some more time but can do. Still working on the tests, reading and making sure I don't miss anything. |
Backported from Syndesis and adapting to Camel standards and requirements. Co-authored-by: Luis Garcia Acosta <lgarciaac@gmail.com>
| title = "Apache Kudu", syntax = "kudu:type", | ||
| consumerClass = KuduConsumer.class, | ||
| label = "database,iot") | ||
| public class KuduEndpoint extends DefaultEndpoint { |
There was a problem hiding this comment.
@Delawen may be rethink about enpoint syntax from separate URI parameters (host and port) to the syntax like in thrift or similar components, i.e. thrift:host:port/service.
for this component it would like kudu:host:port/type that much more cloud ready for services and routes.
Also KuduClientBuilder is using this syntax.
There was a problem hiding this comment.
Makes sense. Thanks!
|
I made it work in Camel 2.25 (this branch) but I am going to work on a PR for 3.x. |
| <dependency> | ||
| <groupId>org.apache.kudu</groupId> | ||
| <artifactId>kudu-client</artifactId> | ||
| <version>${kuduVersion}</version> |
There was a problem hiding this comment.
It would be nice to change to the common format for all components, i.e. kudu-version
There was a problem hiding this comment.
That's already done. I'm going to close this PR and focus on the 3.x branch :)
| KuduClient connection = endpoint.getKuduClient(); | ||
| LOG.debug("Creating table {}", tableName); | ||
|
|
||
| Schema schema = (Schema) exchange.getIn().getHeader("Schema"); |
There was a problem hiding this comment.
It would be nice to have headers name in Camel style like CamelKuduSchema and store them names in separate constant class/interface.
Backported from Syndesis:
https://github.com/syndesisio/syndesis/tree/master/app/connector/kudu