Add handling of offset in case of auto commit is disabled to prevent data loss (CAMEL-8085) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vasilievip
commented
Nov 27, 2014
vasilievip
commented
- add handling of offset if auto commit of offset is disabled
- add embedded kafka into unit tests
- add handling of offset if auto commit of offset is disabled - add embedded kafka into unit tests
vasilievip
changed the title
vasilievip
changed the title
- break iteration if interrupted or barrier is broken
- make barrier await timeout configurable
|
Applied the patch into camel master branch with thanks to Ivan. |
|
will you resolve the jira issue and close this pull request? |
|
@vasilievip we cannot close the github PR so do you mind doing that? |
|
Sure |
|
Hi Guys, For the last batch that is getting processed, offset is not getting commited to ZK. Can you handle this scenario as well? |
tdiesler
pushed a commit
to tdiesler/camel
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.