Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-14250: Allow custom configurations into Kafka component #3468

Merged
merged 2 commits into from Jan 9, 2020
Merged

CAMEL-14250: Allow custom configurations into Kafka component #3468

merged 2 commits into from Jan 9, 2020

Conversation

omarsmak
Copy link
Member

@omarsmak omarsmak commented Jan 8, 2020

My first PR after my holidays and to kick my brain on again :).

Per CAMEL-14250, this will add new optional called additionalProperties. to Kafka component to allow properties that are not covered by KafkaConfigurations

@davsclaus
Copy link
Contributor

I wonder if we can also add this to the component level, so you can configure these globally too for all your kafka endpoints. And then on endpoint level they can be there too, so you can override or provide extra there too.

@omarsmak
Copy link
Member Author

omarsmak commented Jan 9, 2020

I thought about it at first actually but then if it can be set from KafkaConfiguration which eventually means can be set from the component level, I thought that would be enough. However, currently this is not going to work because I have missed to add a check if it was already set on the component level otherwise set it on the configuration. Thanks for the reminder

@omarsmak
Copy link
Member Author

omarsmak commented Jan 9, 2020

@davsclaus did some modification to make additionalProperties through KafkaConfiguration on the component level aware as it wasn't before

@omarsmak omarsmak merged commit 8409231 into apache:master Jan 9, 2020
@omarsmak omarsmak deleted the CAMEL-14250 branch January 9, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants