CAMEL-14387 - fix NPE when client error #3473
Conversation
There was a problem hiding this comment.
Please report the JIRA issue (CAMEL-14387) in the commit message. Personally I don't like the use of this in this way, but it's only a matter of taste.
@zregvart can you have a look? Thanks.
| @@ -16,6 +16,16 @@ | |||
| */ | |||
| package org.apache.camel.component.salesforce.internal.streaming; | |||
|
|
|||
| import static java.util.concurrent.TimeUnit.MILLISECONDS; | |||
There was a problem hiding this comment.
Please run the build with the sourcecheck profile enabled, the static part must be at the end of the imports listing.
| LOG.debug("[CHANNEL:META_HANDSHAKE]: {}", message); | ||
|
|
||
| if (!message.isSuccessful()) { | ||
| LOG.warn("Handshake failure: {}", message); | ||
| handshakeError = (String)message.get(ERROR_FIELD); | ||
| handshakeException = getFailure(message); | ||
| SubscriptionHelper.this.handshakeError = (String)message.get(ERROR_FIELD); |
There was a problem hiding this comment.
What is the reason to add SubscriptionHelper.this for these properties? IMHO it makes the code a bit chaotic, same goes for this.
There was a problem hiding this comment.
Sorry is my mistake... (default configuration of my IDE). I fix this.
There was a problem hiding this comment.
I commited a more correct patch
|
Merged. Thank you @jbdefard ! |
No description provided.