Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAMEL-14401] Restore default host/port properties for IPFS #3479

Merged
merged 1 commit into from Jan 15, 2020

Conversation

tdiesler
Copy link
Contributor

No description provided.

@davsclaus
Copy link
Contributor

-1

Defaults in context-path for host:port works really bad. All the tests and examples have ip and port number anyway. So try to fix it that way instead.

@tdiesler
Copy link
Contributor Author

Similar to Blockchain, users are encouraged to run a local node rather than connecting to a remote node. IMHO "ipfs:add" (as a shorthand for ipfs:127.0.0.1:5001:add) should work.

Are you sure, that only C should work out of those three?

                from("direct:startA").to("ipfs:add");
                from("direct:startB").to("ipfs:127.0.0.1/add");
                from("direct:startC").to("ipfs:127.0.0.1:5001/add");

@tdiesler
Copy link
Contributor Author

IPFS nodes (like blockchain nodes) are expected to mirror content. There are a number of public IPFS nodes out there, that folks can use when they don't want to run a node themselves. Configuring host/port on the component would be fine I think.

How would I do that?

@davsclaus
Copy link
Contributor

You add the options on the component class, and remove them from the endpoint. On component you annotate with @metadata instead of uripath. And on endpoint you update the syntax in the top to just have the command.

@davsclaus
Copy link
Contributor

@davsclaus davsclaus merged commit cbb0426 into apache:master Jan 15, 2020
@tdiesler
Copy link
Contributor Author

Ok, that's done too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants