CAMEL-14633 #3603
Merged
CAMEL-14633 #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py without headers The new two tests will make a safe copy of the exchange. in both tests, the in and the out message have a attachment but in only one of the tests will set an header on the messages before copying the exchange. The test without headers will fail.
Moved logic to copy attachments outside of if-block to check for existence of headers
oscerd
requested changes
Feb 29, 2020
|
Hi, are you referring to this line of the build output? [WARNING] No eip doc file: /Users/olimberg/projects/Java/camel/camel-core/src/main/docs/eips/pipeline-eip.adoc I'll try to figure out how to solve this issue. |
|
No, I'm referring on the warnings you should have when compiling with -Psourcecheck, you should see at least one error at the beginning related to imports order. |
davsclaus
requested changes
Mar 2, 2020
| } | ||
| // just copy the attachments here |
There was a problem hiding this comment.
As attachments are very very seldom in use, then this has negative performance impact. You should check via hasAttachments if any copying is needed.
There was a problem hiding this comment.
Okay, should I apply this change to the out message as well?
…ng the copy method
davsclaus
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.