Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMEL-13844: RestConfiguration - Make it simpler and only have one #3643

Merged
merged 3 commits into from Mar 18, 2020
Merged

CAMEL-13844: RestConfiguration - Make it simpler and only have one #3643

merged 3 commits into from Mar 18, 2020

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

@lburgazzoli lburgazzoli changed the title RestConfiguration - Make it simpler and only have one CAMEL-13844: RestConfiguration - Make it simpler and only have one Mar 17, 2020
@lburgazzoli
Copy link
Contributor Author

@davsclaus ok so I think I have left two test to re-enable and amend to cope with the new set-up but everything else should be almost done, mind having a look ?

davsclaus
davsclaus approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - only the function thingy which seems a bit overkill for me. And btw they add overhead and we dont want Camel to become slow again ;)

core/camel-support/src/main/java/org/apache/camel/support/CamelContextHelper.java Outdated Show resolved Hide resolved
@davsclaus davsclaus marked this pull request as ready for review March 18, 2020 08:45
@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Mar 18, 2020 •
edited

@davsclaus should be ready now (this is the main difference from the previous version)

@lburgazzoli lburgazzoli merged commit 702a6b2 into apache:master Mar 18, 2020
@lburgazzoli lburgazzoli deleted the CAMEL-13844 branch March 18, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davsclaus davsclaus davsclaus approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lburgazzoli @davsclaus @oscerd